Patch for fpimage.inc

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Patch for fpimage.inc

Graeme Geldenhuys-6
Hi,

I received notification of a patch (pull request) via my FPC Git mirror.
The author has been notified to rather use Mantis, but seems to have some
troubles registering.

If anybody with FPC commit access wanted to take a look, the patch can be
found here.

  https://github.com/graemeg/freepascal/pull/11

Commit Summary

    Update fpimage.inc

File Changes

    M packages/fcl-image/src/fpimage.inc (8)

Patch Links:

    https://github.com/graemeg/freepascal/pull/11.patch
    https://github.com/graemeg/freepascal/pull/11.diff


Regards,
  Graeme

--
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp
_______________________________________________
fpc-pascal maillist  -  [hidden email]
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for fpimage.inc

Michael Van Canneyt


On Fri, 5 May 2017, Graeme Geldenhuys wrote:

> Hi,
>
> I received notification of a patch (pull request) via my FPC Git mirror.
> The author has been notified to rather use Mantis, but seems to have some
> troubles registering.
>
> If anybody with FPC commit access wanted to take a look, the patch can be
> found here.
>
>  https://github.com/graemeg/freepascal/pull/11
>
> Commit Summary
>
>    Update fpimage.inc
>
> File Changes
>
>    M packages/fcl-image/src/fpimage.inc (8)
>
> Patch Links:
>
>    https://github.com/graemeg/freepascal/pull/11.patch
>    https://github.com/graemeg/freepascal/pull/11.diff

I have downloaded the patch, will look at it ASAP.
But it's somewhat confusing, because the second patch modifies the first.


Michael.
_______________________________________________
fpc-pascal maillist  -  [hidden email]
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Patch for fpimage.inc

Graeme Geldenhuys-6
On 2017-05-05 14:25, Michael Van Canneyt wrote:
> But it's somewhat confusing, because the second patch modifies the first.

Thanks Michael. I guess it took two attempts to fix the issue at hand. If
that was me, I would probably have flattened the changes to a single commit.

  $ git merge --squash

;-)

Regards,
  Graeme

--
fpGUI Toolkit - a cross-platform GUI toolkit using Free Pascal
http://fpgui.sourceforge.net/

My public PGP key:  http://tinyurl.com/graeme-pgp
_______________________________________________
fpc-pascal maillist  -  [hidden email]
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-pascal
Loading...